fix(startup): Q may fail if Toolkit fails #5731
Merged
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
Problem:
If Toolkit fails to start, then Q will also fail to start:
2024-10-01 09:56:13.188 [error] aws.amazonq.refreshConnectionCallback: [
[TypeError: Cannot read properties of undefined (reading 'getApi')
at c:\…\dist\src\extensionNode.js:6093:284
Solution:
Check for undefined `exports`.
jpinkney-aws
reviewed
Oct 7, 2024
|
|
||
| await assertDoesNotThrow(async () => await fs.checkPerms(credentialsFilename, 'r--')) | ||
| await assertDoesNotThrow(async () => await fs.checkPerms(credentialsFilename, '-w-')) | ||
| await assert.doesNotReject(async () => await fs.checkPerms(credentialsFilename, 'r--')) |
Contributor
There was a problem hiding this comment.
Are these changes somehow related to this PR? Otherwise the change looks good to me
Contributor
Author
There was a problem hiding this comment.
no just a fixup for a recent commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If Toolkit fails to start, then Q will also fail to start:
Solution:
Check for undefined
exports.